Skip to content

fs: suggest --allow-fs-read in lstat permission errors - #66969

Open
RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:suggest-allow-fs-read-in-lstat-permission-errors
Open

RafaelGSS wants to merge 1 commit into
nodejs:mainfrom
RafaelGSS:suggest-allow-fs-read-in-lstat-permission-errors

Conversation

@RafaelGSS

Copy link
Copy Markdown
Member

fs: suggest --allow-fs-read in lstat permission errors

This was missed in #57585.

This was missed in nodejs#57585.

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels Oct 23, 2026
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.58824% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.59%. Comparing base (03cca65) to head (ae0d319).
⚠️ Report is 116 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/fs/promises.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #66969   +/-   ##
=======================================
  Coverage   90.58%   90.59%           
=======================================
  Files         797      797           
  Lines      278297   278305    +8     
  Branches    53515    53526   +11     
=======================================
+ Hits       252096   252123   +27     
+ Misses      16561    16556    -5     
+ Partials     9640     9626   -14     
Files with missing lines Coverage Δ
lib/fs.js 97.18% <100.00%> (+<0.01%) ⬆️
lib/internal/fs/promises.js 91.07% <0.00%> (-0.16%) ⬇️

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model. label Oct 31, 2026
@RafaelGSS

Copy link
Copy Markdown
Member Author

PTAL @nodejs/security-wg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants